Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling window #74

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Scrolling window #74

wants to merge 8 commits into from
+126 −10

Conversation

gutow
Copy link
Contributor

@gutow gutow commented Sep 10, 2022

Thank you for this piece of code. It may solve a looming problem at my institution.

This implements a scrolling window with a reasonable minimum size. This should work better on smaller screens. This addresses issue #16.

Tried to build tests, but because this is not a proper python package it is not practical to build tests that target individual classes or functions. See issue #73.

@iansan5653 iansan5653 mentioned this pull request Sep 12, 2022
Open
iansan5653
iansan5653 previously requested changes Sep 12, 2022
View reviewed changes
Copy link
Owner

@iansan5653 iansan5653 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this work! I definitely want to get this scrolling problem fixed. Unfortunately the licensing issue with the ScrollFrame class makes it impossible for me to merge this (see my comment below). Once that's resolved though, I will definitely approve this!

src/tk_scrollable_frame.py Outdated Show resolved Hide resolved
src/user_interface.py Outdated Show resolved Hide resolved
test/test_user_interface.py Outdated Show resolved Hide resolved
@iansan5653 iansan5653 mentioned this pull request Sep 12, 2022
Merged
@iansan5653 iansan5653 linked an issue Sep 19, 2022 that may be closed by this pull request
The user interface can be too long for some screens #16
Open
@iansan5653
Copy link
Owner

Hello! Just so you know, I will be preparing for Hurricane Ian and will probably be out of power after it hits, so I probably won't be able to check back on these pull requests until next week at the earliest.

@gutow
Copy link
Contributor Author

gutow commented Sep 26, 2022

Hello! Just so you know, I will be preparing for Hurricane Ian and will probably be out of power after it hits, so I probably won't be able to check back on these pull requests until next week at the earliest.

Thanks for the heads up! Stay Safe!

@gutow gutow requested a review from iansan5653 October 14, 2022 21:10
gutow
gutow commented Jan 5, 2023
View reviewed changes
Copy link
Contributor Author

@gutow gutow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original author converted the GIST to a more permissive MIT V2.0 license. This update reflects that.

@iansan5653 iansan5653 dismissed their stale review January 5, 2023 20:05

License fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansan5653 iansan5653 Awaiting requested review from iansan5653

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The user interface can be too long for some screens
2 participants
@gutow @iansan5653